search

openhab / openhab1-addons

Add-ons for openHAB 1.x
Eclipse Public License 2.0
3.43k stars 1.71k forks source link

[pushover] Added HTML and Monospace formatting option #5846

Closed bruestel closed 5 years ago

bruestel commented 5 years ago

Signed-off-by: Jonas Brüstel jonas@bruestel.net (github: bruestel)

cweitkamp commented 5 years ago

I maybe see an issue raising. Currently we check for the length of the message plus the title and suppress to send something when the length exceeds 512 characters.

https://github.com/openhab/openhab1-addons/blob/9f1ee25844da5bb2fa3bd0d088b719c63d1a5f19/bundles/action/org.openhab.action.pushover/src/main/java/org/openhab/action/pushover/internal/Pushover.java#L362

This will happen very quickly when one will start using HTML in his messages. IIRC the used thresholds are not correct anymore. According to https://pushover.net/api#limits we can increase them to 1024 chars for the message and 250 chars for the title.

bruestel commented 5 years ago

Changed title and message length constraints. 2019-04-26 13 41 30

bruestel commented 5 years ago

CI crashed. How can I trigger a new build?

cweitkamp commented 5 years ago

Thanks for the changes.

How can I trigger a new build?

You can close the PR and reopen it :wink:.

schrej-zz commented 4 years ago

Hi, did this went into the 2.5M1? I fail to use ".withHtmlFormatting" and I get an error message, that 'withHtmlFormatting' is not a member of 'org.openhab.action.pushover.internal.Pushover'.

bruestel commented 4 years ago

Hi, did this went into the 2.5M1? I fail to use ".withHtmlFormatting" and I get an error message, that 'withHtmlFormatting' is not a member of 'org.openhab.action.pushover.internal.Pushover'.

I really don't know. I've added the addon as jar file in my installation (2.4). I can send you the jar or you can compile it yourself.