search

openhab / openhab1-addons

Add-ons for openHAB 1.x
Eclipse Public License 2.0
3.43k stars 1.71k forks source link

[fatekplc] Added serial port support #5877

Closed slawekjaranowski closed 4 years ago

slawekjaranowski commented 4 years ago

fix: #5871

Marcin-st commented 4 years ago

Started working after upgrade openhab M2 to M4

openhab-bot commented 4 years ago

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/failed-build-pr-for-openhab1-addons/85410/4

slawekjaranowski commented 4 years ago

I kindly ask about review @openhab/1-x-add-ons-maintainers

9037568 commented 4 years ago

@Marcin-st please clarify your statement. Are you saying that the problem you filed in #5871 is no longer occurring for you? If it is not, please close that ticket.

@slawekjaranowski if that problem is no longer occurring, this PR is not needed?

slawekjaranowski commented 4 years ago

The issue #5871 report that fatekplc binding doesn't have support to communicate by serial line / serial port with plc.

This PR add such possibility, so extends functionality and is needed.

slawekjaranowski commented 4 years ago

During test we talked with @Marcin-st on https://community.openhab.org/t/fatek-binding-to-use-usb-cabel/74509

So text "Started working after upgrade openhab M2 to M4" means that this PR start morking.

Marcin-st commented 4 years ago

Confirm. Fatek now is working with Serial-USB cabel.