search

openhab / openhab1-addons

Add-ons for openHAB 1.x
Eclipse Public License 2.0
3.43k stars 1.71k forks source link

[caldav-personal] Filters now allow any character, but require single quotes #5935

Closed 5iver closed 4 years ago

5iver commented 4 years ago

This change makes single quotes around the filters a requirement, which is what the documentation already shows. Single quotes inside the filter will stop the matching, so they should be replaced with a period (.) in the Item definition. The benefit of this change is that the characters in the filters no longer have any other limitation. Previously, they were limited, as discussed in the forum.

PRs for the documentation are in #5936 and #5937.

Signed-off-by: Scott Rushworth openhab@5iver.com

5iver commented 4 years ago

Any idea why the build failed? Looks systemic, since they've been failing for a month and a half! Maybe OH1 addons are not going into the 2.5.x distro?

openhab-bot commented 4 years ago

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/caldav-personal-regular-expression/84751/15

9037568 commented 4 years ago

Any idea why the build failed?

No, not a clue. Perhaps there's a wizard in the know among the @openhab/add-ons-maintainers

9037568 commented 4 years ago

FWIW, the build was successful in my local.

5iver commented 4 years ago

I have not been successful building this. What procedure did you follow?

9037568 commented 4 years ago

I just used the command line and executed a mvn install from the top of the binding's folder tree.

5iver commented 4 years ago 
[ERROR]   Missing requirement: org.openhab.binding.caldav-personal 1.15.0.qualifier requires 'package org.openhab.io.caldav 0.0.0' but it could not be found
9037568 commented 4 years ago

Can anyone in @openhab/maintainers explain this build failure?

kaikreuzer commented 4 years ago

@openhab-5iver We actually didn't plan to ship any further updates of 1.x add-ons - it isn't included in the 2.5.x release process anymore. I'd only want to revert this and spend additional efforts on it, if really urgent and necessary.

5iver commented 4 years ago

@kaikreuzer , wow... I wish that had been made clearer in the announcements. This PR is not critical, but the filter functionality is pretty much unusable with it. The 2.x version is coming along, so hopefully this binding will be moved to legacy soon anyhow. I suggest communicating in the forum that 1.x bindings are no longer going to be updated in the distro. It makes sense to me to archive the openhab1-addons repo and put in a PR like in the ESH repo to let people know this repo is no longer maintained.

kaikreuzer commented 4 years ago

Well, yes, sorry - I absolutely agree that this should be clearly communicated. I still hesitated because I wasn't sure whether we should really do it or not (that's why I wrote above "didn't plan to"...). For critical fixes, it might still make sense, but it will mean that we have to adapt the 2.5.x build processes and make sure that updates are taken into consideration, which might mean that we could need yet another 2.5.x distro delivery... Something I'd want to avoid.

@openhab/1-x-add-ons-maintainers What do you think how we should go about it?