search

openhab / openhab1-addons

Add-ons for openHAB 1.x
Eclipse Public License 2.0
3.43k stars 1.71k forks source link

Replace "must not" by "need not" #5941

Closed 7usr7local closed 4 years ago

7usr7local commented 4 years ago

I guess it had been a translation error from german - saying "must not be ordered" means it has to be be not in order. That doesn't make sense to me. Guessing from the german wording "muss nicht sortiert sein" I guess the meaning should be that it may be or may be not sorted - which is "need not be ordered" in english.

7usr7local commented 4 years ago

Hi @9037568,

propably I got something wrong - I just tried to improve the documentation public available here: https://www.openhab.org/addons/bindings/caldav-personal1/ with a text at the bottom

"Caught a mistake or want to contribute to the documentation? Edit this page on GitHub"

containing a link I followed which lead me to create that pull request.

The only thing I can say for sure is

Maybe I made the wrong improvement because I didn't get the meaning right. (Maybe it really must not be ordered - but what for? If the code does not rely on the order - the order should not matter at all, isn't it? If it must not be ordered in a special way - it would be more reasonable to mention the way it should be ordered.)

Maybe I didn't do the improvement at the right place, because the link pointed to a wrong location.

Maybe I missed some formalism because I tried to help without studying the projects charta.

Maybe the text at the bottom is just void, and help by non-members is not appreciated.

Maybe ... something completely different is happening.

9037568 commented 4 years ago

There's nothing wrong with what you did. But this repository is closed and not taking updates.

7usr7local commented 4 years ago

Hello @9037568 ,

thanks to replying to my question. I am still not sure, I got it right. Is it because openhab1 is deprecated? So what's the way to correct errors in its documentation? Sorry for taking so long to respond, I somehow missed your reaction.

Thanks,

Peter

ptrooms commented 4 years ago

Hello @9037568 ,

thanks to replying to my question. I am still not sure, I got it right. Is it because openhab1 is deprecated? So what's the way to correct errors in its documentation? Sorry for taking so long to respond, I somehow missed your reaction.

Thanks,

Peter

As I do understand it is more strategic. The (ability to) support of OH1 bindings by "community lead-engineers" went simply by "choice" into a (forced?) stop. Perhaps to get rid off the old-factory (architecture) that's in the way of making a new - independant ? - approaches.

I can also imagine that the original way of doing things is becoming to difficult and/or violating "developing" rights and/or while the founding "smarthome" platform is archived by Eclipse and thus no longer receives that founded company support. Consequences is that OH1 is dropped which will in time might hit OH2 in favor of the upcoming brand-new OH3 architecture.

Note: for individual programming, nothing much will change other thamn finding out how to compile at home. One can make own changes but these are no longer supported/maintained offically. At every change/revision in the supplied core, one must verify/check/adapt things themselves.

5iver commented 4 years ago

https://github.com/openhab/openhab-core/pull/1284

This also contains a link to the discussion.