search

openhab / openhabian

openHABian - empowering the smart home, for Raspberry Pi and Debian systems
https://community.openhab.org/t/13379
ISC License
821 stars 251 forks source link

Various BATS tests fail on Ubuntu #1161

Open mstormi opened 3 years ago

mstormi commented 3 years ago

Telldus because of outdated repo to still refer to stretch? wireguard because of missing dnsutils

We should consider dropping Ubuntu support or to be more specific in that these addons will not be supported on Ubuntu. @ecdye @holgerfriedrich wdyt?

ecdye commented 3 years ago

This was your desire, to support Ubuntu, if you feel that it is not wise to add official support for it at the moment, I see not issue with that.

mstormi commented 3 years ago

Desire, well ... am I right that none of us (you, me, @holgerfriedrich) has access to an Ubuntu development box ? (other than that in Travis, but that's awkward trial-and-error if not interactively useable). About the code, ok we should try to keep it Ubuntu compatible. But we cannot actively test against Ubuntu. Adding these BATS tests somewhat opened my eyes. So many of the optional components that fail to run and that we never even tried to run/test before. I think we cannot and therefore should not reliably promise "support" for Ubuntu. We can provide it "as-is", though.

ecdye commented 3 years ago

I think we cannot and therefore should not reliably promise "support" for Ubuntu. We can provide it "as-is", though.

That sounds good to me.

mstormi commented 3 years ago

See my docs changes from #1164 and let me know if I need to change anything about it again.

mstormi commented 3 years ago

See https://community.openhab.org/t/openhab-logviewer-died-on-me-solved/106021/19 (openhabian group missing makes frontail fail to install)

I'd think that a lot of these issues could be related to the code that renames the existing administration user (group, too?) into "openhabian". That exists in the RaspiOS image but likely not on Ubuntu.

holgerfriedrich commented 3 years ago

Just to summarize what I noticed yesterday: