search

openhab / openhabian

openHABian - empowering the smart home, for Raspberry Pi and Debian systems
https://community.openhab.org/t/13379
ISC License
822 stars 251 forks source link

Properly use second argument of fix_permissions #1578

Closed spacemanspiff2007 closed 2 years ago

spacemanspiff2007 commented 3 years ago

closes #1577

Signed-off-by: Sebastian Gerber git@sgerber.de

ecdye commented 3 years ago

@spacemanspiff2007 Please follow the instructions under the DCO check to fix the issue. Once the DCO is fixed I will merge.

spacemanspiff2007 commented 3 years ago

@ecdye While looking through the history I noticed you (removed the pip part) and it's not clear to me why. Could you explain it to me?

  if ! cond_redirect python3 -m pip install --upgrade pip habapp; then echo "FAILED"; return 1; fi

to 

  if ! cond_redirect python3 -m pip install --upgrade habapp; then echo "FAILED"; return 1; fi
ecdye commented 3 years ago

We want apt to be upgrading pip, not python, does it cause an issue with HABapp?

spacemanspiff2007 commented 3 years ago

We want apt to be upgrading pip, not python, does it cause an issue with HABapp?

It's only upgrading pip in the newly created venv. If the user hasn't upgraded in a while HABApp won't install if pip is below a certain version. This ensures that the installation always possible even if the user was lazy with update.

spacemanspiff2007 commented 2 years ago

I somehow got the rebase wrong and deleted all changes

spacemanspiff2007 commented 2 years ago

@ecdye I added the change I remembered but the rest got lost. Failing test is homegear so imho this is good to be merged

spacemanspiff2007 commented 2 years ago

I followed the exact steps in the DCO and now it deleted all changes again.

spacemanspiff2007 commented 2 years ago

@ecdye I don't know how to get the DCO to pass and the steps suggested are not working. Is there anywhere a good explanation how to set everything up properly? Otherwise we'll just leave it buggy and you can close this PR - this has been super frustrating for me especially since we've lost the changes from the first PR.