openhab / openhabian

openHABian - empowering the smart home, for Raspberry Pi and Debian systems
https://community.openhab.org/t/13379
ISC License
821 stars 252 forks source link

Amanda mail address not queried for on interactive install #1605

Closed mstormi closed 2 years ago

mstormi commented 2 years ago

After a fresh interactive install, /etc/amanda/openhab-dir/amanda.conf had mailto=root@openhab but this should have been the user-entered mail address Conditions TBD, pls try to reproduce yourself

ecdye commented 2 years ago

No it is correct. On initial install you have to set the email otherwise it will use that as the default.

mstormi commented 2 years ago

It does not ask on interactive install. It should. backup.bash L335

ecdye commented 2 years ago

It does not ask on interactive install. It should. backup.bash L335

Ohh, I missed the part about it being interactive, sorry. Let me look into it.

ecdye commented 2 years ago

Huh, you're right the code for interactive mail choice is completely missing, I guess when we made it uninteractive capable we must have accidentally removed it. It's weird because I remember it working when I set up my current production machine. Looking at the mail code leads me to believe in some weird way we intended for the user to set up exim and choose an admin mail address on their own and set it in the config so it all had to be done uninteractive this is really weird. I wonder if git history might explain a little better.