search

openhab / openhabian

openHABian - empowering the smart home, for Raspberry Pi and Debian systems
https://community.openhab.org/t/13379
ISC License
820 stars 252 forks source link

Fix nginx authentication setup prompt #1638

Closed No3x closed 2 years ago

No3x commented 2 years ago

Prompt for username and password did not show up because $auth was checked for "yes" instead of "true" (set 2 lines before).

ecdye commented 2 years ago

The change looks good, can I have you follow the instructions on the DCO test that failed to fix it so we have a proper sign off?

No3x commented 2 years ago

I just noticed that this is not sufficient to fix basic auth setup. Later there is a openhab2_installed check where the credentials are used which is not executed on oh3 install. Changed this too assuming that it's fine for oh2 and oh3 as well. Please check the change.