openhab / openhabian

openHABian - empowering the smart home, for Raspberry Pi and Debian systems
https://community.openhab.org/t/13379
ISC License
820 stars 251 forks source link

Add zigbee2mqtt #1656

Closed Larsen-Locke closed 2 years ago

Larsen-Locke commented 2 years ago

Zigbee2mqtt is used by many openhab-users as it greatly increases the number of possible ZigBee-hardware for openhab (especially sensors and switches that don't implement the ZigBee-standard very accurate)

The possibility to install and update zigbee2mqtt would in my opinion make a perfect fit.

There is nothing that has to be configured during installation cause everything can be set up in the (great) web frontend afterwards.

I would like to know what you think and how I can contribute.

mstormi commented 2 years ago

With the ZigBee and deCONZ bindings in openHAB at hand there is little benefit in going for a more complicated and error prone setup as is Zigbee2mqtt. I would be accepting a PR to add Zigbee2mqtt to openHABian but I will not start work on that myself.

Larsen-Locke commented 2 years ago

Thank you for your answer. I understand that it's not on your list which is perfectly ok. But just let me explain why many want or have to use zigbee2mqtt to integrate their hardware: Only well implemented zigbee hardware gets identified by the openhab-binding. Many of the chinese zigbee devices just don't work with the binding (e.g. Livolo zigbee) as well as many coordinators (e.g. chipset TI 2652P with a really good range). Another argument is that with zigbee2mqtt you can immediately see the complete topology of your mesh and test the device. This is very helpfull if something doesn't work. Thank you for your good work.

Larsen-Locke commented 2 years ago

allright. Let's give it a try: I added a menu for zigbee2mqtt under "optional components" and added download and install-functionality in nodejs-apps.bash What might be missing is a test routine in the .bats-file. I start the PR..

Larsen-Locke commented 2 years ago

Well it got a lot bigger than I expected. I think now it covers most of what's necessary like installing, removing, updating. You can set the mqtt user and password if necessary. Please tell me what to improve. PR is https://github.com/openhab/openhabian/pull/1666

Larsen-Locke commented 2 years ago

Finally all checks are passed without error and all requested corrections are implemented. Well, a lot more work than I expected, especially getting permissions right took me a while. Hope the PR gets accepted now.