search

openhab / openhabian

openHABian - empowering the smart home, for Raspberry Pi and Debian systems
https://community.openhab.org/t/13379
ISC License
818 stars 251 forks source link

Update menu.bash #1698

Closed MatzeMuc86 closed 1 year ago

MatzeMuc86 commented 2 years ago

Add experimental explanation for openjdk 17 Add activate explanation for openjdk

MatzeMuc86 commented 1 year ago

Please remove the "experimental" as it isn't a proper term to describe this option. Installing JDK17 is not experimental. Running OH on Java17 is (somewhat).

Also please fix DCO.

Happy to correct. As I do not know the technical details, it is hard for me to find the proper wording. If I understood correct, Java 11 is kind of "default" while Java 17 is not? Maybe you can give me some background and I can suggest proper formulation for the menu. My goal would be to guide less experienced people to the potentially more stable / preferred option.

mstormi commented 1 year ago

add "(default)" to JDK11 menu option and remove the "(experimental)"

MatzeMuc86 commented 1 year ago

add "(default)" to JDK11 menu option and remove the "(experimental)"

Done.

I tried to activate DCO - I hope this works!

mstormi commented 1 year ago

I tried to activate DCO - I hope this works!

Unfurtunately not you didn't sign your commit See explanation at https://github.com/openhab/openhabian/pull/1698/checks?check_run_id=7653786889