search

openhab / openhabian

openHABian - empowering the smart home, for Raspberry Pi and Debian systems
https://community.openhab.org/t/13379
ISC License
818 stars 251 forks source link

Add support for installing `openhab` & `openhab_rules_tools` from npm #1714

Closed florian-h05 closed 1 year ago

florian-h05 commented 1 year ago

Fixes #1651.

This PR adds a menu option to install the openHAB JavaScript library and openhab_rules_tools from @rkoshak.

florian-h05 commented 1 year ago

@mstormi This is nearly ready for merging.

At every start of the openhabian-config tool, it checks the following for both openhab & openhab_rules_tools:

  1. Does the package folder exist? If not, exit.
  2. Run npm outdated and check for the package name in the output. If the package is mentioned in the output, an update is available.
  3. Ask the user for updating.

In the openhabian-config tool, you can install both packages under 40 | openHAB Related.

I only need your help where to put the command for auto-installing openhab_rules_tools.

florian-h05 commented 1 year ago

@rkoshak @mstormi Sorry for the chaos with the review requests. I‘m somehow not able to request a re-review from both of you using the „request review“ button.

rkoshak commented 1 year ago

Short of being able to test this myself all I can say is LGTM.

florian-h05 commented 1 year ago

I tested all recent changes just a few minutes ago, everything works.

Should be ready for merging @mstormi.

mstormi commented 1 year ago

please rebase to include a fix I've just to main (it should make the installation tests pass)

florian-h05 commented 1 year ago

@mstormi I addressed your review and rebased, retested all current changes and everything works. From my side this is ready for merging, feel free to re-review.

florian-h05 commented 1 year ago

@mstormi I updated the whiptail menu size:

IMG_1715

mstormi commented 1 year ago

There's a branch inside openhabian-setup.sh that's executed for unattended installs. Put it somewhere after openhab installation.Am 13.09.2022 15:24 schrieb Florian Hotze @.***>: @mstormi This is nearly ready for merging. At every start of the openhabian-config tool, it checks the following for both openhab & openhab_rules_tools: Does the package folder exist? If not, exit.Run npm outdated and check for the package name in the output. If the package is mentioned in the output, an update is available.Ask the user for updating. In the openhabian-config tool, you can install both packages under 40 | openHAB Related. I only need your help where to put the command for auto-installing openhab_rules_tools.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>