Fix & Improve frontail installation

[florian-h05]

@mstormi Here is your fix, I‘ve also improved the frontail installation process and removed the usage of the --force flag, because this can install breaking changes and therefore can break frontail.

Description

• Fixes https://github.com/openhab/openhabian/issues/1743 by ignoring exit code 1. This is thrown when "npm audit fix" is unable to fix all vulnerabilities.
• Do NOT use the "--force" flag for npm, otherwise breaking changes may be installed.
• Improves the installation process by:
  1. Fixing vulnerabilities of production dependencies
  2. Updating production dependencies
  3. After these operations, globally installing frontail without dev dependencies

Signed-off-by: Florian Hotze florianh_dev@icloud.com

Testing

Before the test, frontail installation was not working on my openHABian Pi 3, with the changes in this PR, frontail installation is working fine.

[mstormi]

@florian-h05 please see my comment .

Also check out the failing BATS test https://github.com/openhab/openhabian/actions/runs/3576426170/jobs/6014216859#step:7:246 It means that in the VM launched that openHABian is installed into for the purpose of testing your PR, frontail isn't running after the previous command (should have) started it. To determine why you would need to experiment a bit. Add debug info gathering commands around that code location, update the PR to trigger another build run and revisit the resulting BATS build log.

[mstormi]

Please cancel build jobs when you override/start subsequent ones. Eventually also cancel the "installation" type of jobs. There's a limit on the amount of build resources the openHAB project can consume, and openHABian test builds are quite big consumers.

[florian-h05]

Please cancel build jobs when you override/start subsequent ones. There's a limit on the amount of build resources the openHAB project can consume.

I‘m sorry that I have started so many build jobs. Originally, I wanted to run BATS locally on my machine, but my Docker seems to have a DNS issue. Therefore, I started using the BATS from the GitHub actions. When I noticed that I started that many jobs, I wanted to cancel them, but I obviously don‘t have the permission. Next, I created another branch and enabled the actions on my fork to continue debugging there. The last push to this PR should pass all checks.

@mstormi Can you please cancel https://github.com/openhab/openhabian/actions/runs/3595126359?

[mstormi]

No worries, just keep it in mind next time.

Glad you found the issue. So the PR can be merged now ?

[florian-h05]

So the PR can be merged now ?

Yes, I just want to wait for the remaining workflow (rpi4-bats) to finish.

[MrRSK]

@mstormi @florian-h05 I'm totally new to GitHub, so is this fix already implemented in the latest version of Raspberry Pi Imager or the downloadable Image?

[florian-h05]

No, as there has been no new release of openHABian since this was merged (the last release was published on Aug 15: https://github.com/openhab/openhabian/releases/tag/v1.7.4b), this is not available in the Raspberry Pi Imager or the downloadable image yet.

BUT: If you are already on openHABian, you can update to the fixed version:

1. sudo openhabian-config
2. If you are already on the main branch, the config tool will ask if you want to update — yes. If not, select 01 Select Branch, then latest.
3. Select 20 Optional Components, then 21 Log Viewer.

[MrRSK]

Thanks, installation completed without any errors.