search

openhab / org.openhab.binding.zigbee

openHAB binding for ZigBee
Eclipse Public License 2.0
74 stars 112 forks source link

Add Tuya button support #629

Closed dschall closed 2 years ago

dschall commented 3 years ago

This change adds support for various Tuya / Zemismart battery-operated switches. These devices send custom Zigbee commands (ID: 253) and expose duplicate PowerConfiguration endpoints.

openhab-bot commented 3 years ago

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/adding-support-for-tuya-zs3l-tz3000-ts0043-ts0042-ts0041-to-zigbee-bindings/108895/46

dschall commented 3 years ago

todo: add tests

cdjackson commented 3 years ago

Thanks @dschall - at the very top level, I think the approach looks fine - thanks for looking at this. I've only quickly scanned the code to check a few things I had in mind that could be problematic and these look ok, so I will take a better look in a few days.

dschall commented 3 years ago

Thanks @dschall - at the very top level, I think the approach looks fine - thanks for looking at this. I've only quickly scanned the code to check a few things I had in mind that could be problematic and these look ok, so I will take a better look in a few days.

Hey @cdjackson, I've added tests and fixed a bug. I think now the PR is ready to merge. I would appreciate comments.

dschall commented 3 years ago

@cdjackson Hey Chris, can we merge this?

cdjackson commented 3 years ago

Sorry - I have limited time right now and probably for about the next 2 weeks. Due to travel restrictions we have to move house in very short time.

dschall commented 3 years ago

@cdjackson, gentle ping to please review this PR :)

suppressio commented 3 years ago

Hi... I'm interested too... another gentle ping to review this PR ...

cdjackson commented 3 years ago

Sorry - I'm in the process of moving and have limited time. I will try and look at this in the next few weeks as things hopefully calm down. I will likely refactor this into a separate bundle.

dschall commented 3 years ago

@cdjackson, gentle ping. Are you going to rewrite this into a separate bundle, or should I resolve the conflicts and complete this PR (assuming you'd sign off on it).

gauthier12 commented 3 years ago

Hi. I'm interested too. Maybe it is better to resolve the conflicts and merge instead of losing the development. It is possible to refactor into a separate bundle later

deeja commented 3 years ago

@cdjackson - would you have any time to look at this again? I just got one of these switches and pretty excited to get it running! Will shout you a beer :D

cdjackson commented 3 years ago

Sorry for the delay with this - I will try and take a look at this over the next few days.

openhab-bot commented 2 years ago

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/adding-support-for-tuya-zs3l-tz3000-ts0043-ts0042-ts0041-to-zigbee-bindings/108895/55

cdjackson commented 2 years ago

@dschall firstly, sorry for the slight pettiness on the logging format but I like to try and keep things standard so any searches, or log viewer type processing has a consistent format to look for...

Otherwise I'm happy enough with this - it all looks good so if you can make those couple of small changes I'll merge.