[Zigbee] ZigbeeThingHandler exception, possibly causing my Aqara things to always appear offline

bjerregaardp commented 3 years ago

I select Zigbee binding and click Scan. Then I press the button on the Aqara device till its LED starts blinking.

Expected Behavior

No exceptions in the log. Zigbee Node updates should make it all the way from discovery to UI.

Current Behavior

Aqara devices are always listed as either GONE or OFFLINE.

2021-05-23 12:00:49.894 [DEBUG] [bee.discovery.ZigBeeDiscoveryService] - 00158D00067C1BA7: Node discovery not complete
2021-05-23 12:01:08.518 [DEBUG] [ng.zigbee.handler.ZigBeeThingHandler] - 00158D00067C1BA7: Node updated - ZigBeeNode [state=ONLINE, IEEE=00158D00067C1BA7, NWK=5C66, endpoints=[]]
2021-05-23 12:01:08.519 [WARN ] [zsmartsystems.zigbee.ZigBeeExecutors] - Uncaught exception in thread NotificationService-thread-9
java.lang.NullPointerException: null
    at org.openhab.binding.zigbee.handler.ZigBeeThingHandler.nodeUpdated(ZigBeeThingHandler.java:879) ~[?:?]
    at com.zsmartsystems.zigbee.ZigBeeNetworkManager$14.run(ZigBeeNetworkManager.java:1735) ~[?:?]
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) ~[?:?]
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) ~[?:?]
    at java.lang.Thread.run(Thread.java:829) [?:?]

The IEEE value in the logline matches the last part of the zigbee device id of a Thing.

Possible Solution

Steps to Reproduce (for Bugs)

I select Zigbee binding and click Scan.
Then I press the button on the Aqara device till its LED starts blinking.

Context

Your Environment

Version used: OpenHAB 3.1.0.M4
Environment name and version (e.g. Chrome 76, Java 8, Node.js 12.9, ...): Edge, Zulu 11
Operating System and version (desktop or mobile, Windows 10, Raspbian Buster, ...): Windows 10
Device: Aqara button WXKG11LM

wborn commented 3 years ago

Can you transfer this issue to the zigbee repo @kaikreuzer?

bjerregaardp commented 3 years ago

I would love to, but I don't get a [Transfer issue] menu or button. (Missing permissions?) I can close this one and make a new identical issue in the zigbee repo if you want.

wborn commented 3 years ago

Me neither, you only see it if you have the right permissions in both repos. That's why I mentioned Kai. 😉

cdjackson commented 3 years ago

Please provide the full debug log. Please read the binding docs to learn how to enable this.

cdjackson commented 3 years ago

Closing this due to lack of information. Please feel free to reopen if you can provide more information, and preferably the debug log showing the issue, as requested previously.

joni1993 commented 2 years ago

I am experiencing a similar issue with my Smabit Contact. The device is seen when Scanning but upon adding it is stuck at "Node has not completed discovery" + OFFLINE.

https://gist.github.com/joni1993/ade408378f77bb3dd39b25f91bdebe0b

cdjackson commented 2 years ago

I'd suggest to open a new issue and provide all the information requested when opening an issue.

openhab / org.openhab.binding.zigbee