search

openhab / org.openhab.binding.zigbee

openHAB binding for ZigBee
Eclipse Public License 2.0
73 stars 111 forks source link

Build KAR to simplify dependency management #699

Closed cdjackson closed 2 years ago

cdjackson commented 2 years ago

@wborn you may have noticed I up-reved the ZSmart Systems libraries a day or so ago. As suggested previously you wanted a KAR to simplify the dependency management, so this PR now creates the KAR which includes these dependencies.

Signed-off-by: Chris Jackson chris@cd-jackson.com

wborn commented 2 years ago

How does another KAR exactly simplify dependency management? All zigbee dependencies are already part of openhab-addons-3.x.y.kar. It's the online repo where these dependencies currently need to be manually added, see https://github.com/openhab/org.openhab.binding.zigbee/pull/676.

cdjackson commented 2 years ago

How does another KAR exactly simplify dependency management?

Ok, sorry - I thought that the comment from @kaikreuzer was requesting that the KAR be added here so that the dependencies were all in one place so that you didn't need to manage them separately upstream.

In the link you referenced, Kai said -:

In the past we used the KAR file and exploded that as a remote repo - it contains everything that is needed, but nothing more. If we could find a similar mechanism, this would imho be ideal.

As I understand at the moment, you, or Kai, need to manually download the JAR from central and upload them to the OH repo. I understood the comment as being you wanted me to create the KAR with the dependencies included, so that they could be exploded in the addons processing?

wborn commented 2 years ago

I understood the comment as being you wanted me to create the KAR with the dependencies included, so that they could be exploded in the addons processing?

I think @kaikreuzer meant to use the current add-ons KAR, and either automatically add all the content to Artifactory using some script... or maybe it can even be added to any CDN as static content. I did notice there are no POM files in a KAR, but if it worked previously like that, that may not be an issue for Karaf. :slightly_smiling_face:

cdjackson commented 2 years ago

Ok, I've not looked at where the various OH repositories pull dependencies from and I understood from the previous discussion that you were pulling everything from an OH specific repo even at build time. Therefore I thought that providing the dependencies here meant that you didn't need to manage this elsewhere.

I'll leave it to you guys to manage then - I'm just trying to make it easier so that the zigbee binding can be built with the minimum of fuss.

kaikreuzer commented 2 years ago

I think @kaikreuzer meant to use the current add-ons KAR, and either automatically add all the content to Artifactory using some script...

That's correct.

I did notice there are no POM files in a KAR, but if it worked previously like that, that may not be an issue for Karaf.

I'm not 100% certain here. It might be that Bintray used to create dummy pom.xmls when uploading artifacts and hence Karaf was happy with it. But Artifactory doesn't do this and therefore the artifacts are not resolved.

I'm just trying to make it easier

Thanks for trying. I'll upload the libs manually again for now.

kaikreuzer commented 2 years ago

Btw @cdjackson, is it correct that there is no version 1.4.2 of the console bundle for Ember, see https://mvnrepository.com/artifact/com.zsmartsystems.zigbee/com.zsmartsystems.zigbee.console.ember?

cdjackson commented 2 years ago

Strange - no - everything should have been built together, so this should also be there. It’s strange that the binding builds if this is missing (both locally and on Jenkins).

It does seem to be there if I link directly though -:

https://mvnrepository.com/artifact/com.zsmartsystems.zigbee/com.zsmartsystems.zigbee.console.ember/1.4.2

https://repo1.maven.org/maven2/com/zsmartsystems/zigbee/com.zsmartsystems.zigbee.console.ember/1.4.2/

So it seems to just be an issue with this web index and the artefacts are really there.

On 15/11/2021, at 9:53 AM, Kai Kreuzer @.***> wrote:

Btw @cdjackson https://github.com/cdjackson, is it correct that there is no version 1.4.2 of the console bundle for Ember, see https://mvnrepository.com/artifact/com.zsmartsystems.zigbee/com.zsmartsystems.zigbee.console.ember https://mvnrepository.com/artifact/com.zsmartsystems.zigbee/com.zsmartsystems.zigbee.console.ember?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openhab/org.openhab.binding.zigbee/pull/699#issuecomment-968361471, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAH6IQ7VHEAVIR6NH5ENJ6LUMAOUVANCNFSM5H7CBOFA. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.