search

openhab / org.openhab.binding.zigbee

openHAB binding for ZigBee
Eclipse Public License 2.0
73 stars 111 forks source link

Update README.md with more HW and FW information #702

Closed Hedda closed 2 years ago

Hedda commented 2 years ago

Update README.md for Zigbee Binding with more HW and FW information

cdjackson commented 2 years ago

@Hedda I just did a search on your proposed text and found that you have cut and paste this from another project which I'm definitely not comfortable with. Please read the contribution guidelines also and please sign the commit to say that you wrote this text or have the right to it.

Hedda commented 2 years ago

@Hedda I just did a search on your proposed text and found that you have cut and paste this from another project which I'm definitely not comfortable with.

@cdjackson FYI, yes I copied text from another project but it was I who wrote that text for that project so yes I do have the right:

https://github.com/zigpy/bellows/commits?author=Hedda

https://github.com/zigpy/zigpy/commits?author=Hedda

Hedda commented 2 years ago

Please read the contribution guidelines also and please sign the commit to say that you wrote this text or have the right to it.

Can I sign that online somewhere? ...makes me wonder why it needs to be so complicated and hard to update documentation for a binding? This is documentation and not code. Are non-coders supposed to be able to help with documentation? I don't like Git

Hedda commented 2 years ago

Please read the contribution guidelines also and please sign the commit to say that you wrote this text or have the right to it.

Can I sign that online somewhere? ...makes me wonder why it needs to be so complicated and hard to update documentation for a binding? This is documentation and not code. Are non-coders supposed to be able to help with documentation? I don't like Git

OMG! https://community.openhab.org/t/dco-check-signing-off-with-github-web-editor-explanation/83330

No wonder there are not a lot of docs contributers to openHAB.

cdjackson commented 2 years ago

Hey @Hedda.

it was I who wrote that text for that project

Thanks - if you wrote this then as I said above that's fine - we just need to make sure that yo have ownership or approval to use the text.

Can I sign that online somewhere?

Yes, you just need to put this one line in the commit and preferably also in the PR. It's very simple - just write the one "signed off by" line as per the contributions file -:

Signed-off-by: Joe Smith <joe.smith@email.com> (github: github_handle)

No wonder there are not a lot of docs contributers to openHAB.

Well, really, it's not that hard. If you take all this time to write the docs then writing this one line is simple. Most git software provides a mechanism to do this automatically as well.

Hedda commented 2 years ago

Closing since apparently not possible to add signed-off to existing commits via GitHub web interface. Maybe I create a new PR later or maybe not. No promises as DCO signing method totally killed my mood for now. Posted complain here:

https://community.openhab.org/t/dco-check-signing-off-with-github-web-editor-explanation/83330

Hedda commented 2 years ago

Reopen now that DCO should no longer be needed for providing docs contributions:

https://community.openhab.org/t/dco-check-signing-off-with-github-web-editor-explanation/83330/27

Hedda commented 2 years ago

Nope, apparently, DCO is still needed on existing/old PRs. closing again