Closed WestCoastXS closed 1 year ago
As discussed with @cdjackson on the openhab forum.
Thanks @WestCoastXS - this looks ok to me in general. I assume you've tested this, and the files look ok, but of course I can't test here.
Just 2 comments.
@WestCoastXS I didn't spot that you have updated this PR - is it now ready as far as you are concerned? If so I'll do a last scan and hopefully get it merged.
Hi @cdjackson , No, I have not been able to get the channels for time and outside temperature going. Haven't given up, just got busy with work. Intending to get back to it soon.
I know there's a procedure to submit the PR, real name, etc, and will do that when I have it working.
This pull request has been mentioned on openHAB Community. There might be relevant details there:
https://community.openhab.org/t/sinope-zigbee-thermostat-th1123zb/129479/48
Static Definitions for Sinope TH1400ZB, TH1123ZB and TH1124ZB thermostats.