search

openhab / org.openhab.binding.zigbee

openHAB binding for ZigBee
Eclipse Public License 2.0
73 stars 111 forks source link

Improve state consistency in level control converter #769

Closed cdjackson closed 2 years ago

cdjackson commented 2 years ago

This adds support for lambda expression in the base converter class to allow the converter to manage what it does when a command completes.

It then changes the way the level control converter works as it needs to manage the local variables that maintain the current state to avoid the level being set to a new, then old level when a command is sent.

Closes #768 Signed-off-by: Chris Jackson chris@cd-jackson.com

openhab-bot commented 2 years ago

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/item-node-is-not-updated-when-a-report-attributes-command-is-received/136463/20

cdjackson commented 2 years ago

Jenkins reports this build successful, but the status is unstable.

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for openHAB Add-ons :: Bundles :: ZigBee Reactor 3.3.0-SNAPSHOT:
[INFO] 
[INFO] openHAB Add-ons :: Bundles :: ZigBee Reactor ....... SUCCESS [ 55.388 s]
[INFO] openHAB Add-ons :: Bundles :: ZigBee Binding ....... SUCCESS [ 39.835 s]
[INFO] openHAB Add-ons :: Bundles :: ZigBee Serial Driver . SUCCESS [ 21.852 s]
[INFO] openHAB Add-ons :: Bundles :: ZigBee CC2531 Bridge . SUCCESS [ 19.217 s]
[INFO] openHAB Add-ons :: Bundles :: ZigBee Console ....... SUCCESS [ 18.078 s]
[INFO] openHAB Add-ons :: Bundles :: ZigBee Ember Bridge .. SUCCESS [ 24.499 s]
[INFO] openHAB Add-ons :: Bundles :: ZigBee Console Ember . SUCCESS [ 10.555 s]
[INFO] openHAB Add-ons :: Bundles :: ZigBee Telegesis Bridge SUCCESS [ 18.976 s]
[INFO] openHAB Add-ons :: Bundles :: ZigBee Console Telegesis SUCCESS [ 12.565 s]
[INFO] openHAB Add-ons :: Bundles :: ZigBee XBee Bridge ... SUCCESS [ 14.945 s]
[INFO] openHAB ZigBee :: BOM :: openHAB ZigBee Binding .... SUCCESS [  0.614 s]
[INFO] openHAB Add-ons :: Features :: Karaf :: openHAB ZigBee Binding SUCCESS [  7.561 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  02:27 min (Wall Clock)
[INFO] Finished at: 2022-06-18T22:33:09Z
[INFO] ------------------------------------------------------------------------

It builds fine locally as well. Jenkins seems to have some sort of issue as it continues to show about 50 commits in this PR (as it has done now for a long time).