search

openhab / org.openhab.binding.zigbee

openHAB binding for ZigBee
Eclipse Public License 2.0
73 stars 111 forks source link

Fix build #798

Closed J-N-K closed 1 year ago

J-N-K commented 1 year ago

Signed-off-by: Jan N. Klug github@klug.nrw

openhab-bot commented 1 year ago

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/openhab-4-0-snapshot-discussion/142322/169

J-N-K commented 1 year ago

The issue is a bug in spotbugs that reports an error when using foo instanceof Bar bar checks, so that needs a suppression (SA_LOCAL_SELF_COMPARISON). If we only add that suppression, then other issues pop up and we need to add some more (not all that are added here), for consistency I decided to copy the file from openhab-core to openhab-addons and that somehow caused the build to fail here because of the changes in the parent POM.

kaikreuzer commented 1 year ago

Alright, thanks for the explanation!