openhab / org.openhab.binding.zigbee

openHAB binding for ZigBee
Eclipse Public License 2.0
73 stars 111 forks source link

Fix battery voltage cluster reference #817

Closed cdjackson closed 6 months ago

cdjackson commented 6 months ago

Hopefully fixes #816

@rkoshak I'll merge this shortly but as I'm travelling haven't been able to test it. Please can you confirm (or not!) that this is resolved. Thanks.

rkoshak commented 6 months ago

Will do. Does this get added to the new snapshot automatically or do I need to pick the jar file up from somewhere else? ~~Just based on time I'm guessing that this change is in the add-ons build that completed a couple hours ago. I'll try with that jar file and report what happens. ~~

Oops, I forgot Zigbee is it's own build and that hasn't run since November 19th according to jFrog. I'll hunt around and see if I can find one. A hint would be appreciated though.

Thanks!

cdjackson commented 6 months ago

Strange - it should have been included in the latest snapshot and I'd not noticed that it wasn't running any more.

cdjackson commented 6 months ago

Try this -:

https://ci.openhab.org/view/Pull%20Request%20Builds/job/PR-org.openhab.binding.zigbee/

rkoshak commented 6 months ago

Unfortunately I can't seem to find any place where the build artifact is. I can see the static code analysis and the test results and even see what commits are in the build but I can't figure out where the .jar file is. I clicked around a bit and ended up back on Jfrog and the build from November. Clearly I'm missing something obvious.

FranzSchi commented 6 months ago

Maybe here? https://openhab.jfrog.io/ui/native/libs-snapshot-local/org/openhab/addons/bundles/org.openhab.binding.zigbee/4.1.0-SNAPSHOT/

Am Di., 12. Dez. 2023 um 21:05 Uhr schrieb Richard Koshak < @.***>:

Unfortunately I can't seem to find any place where the build artifact is. I can see the static code analysis and the test results and even see what commits are in the build but I can't figure out where the .jar file is. I clicked around a bit and ended up back on Jfrog and the build from November. Clearly I'm missing something obvious.

— Reply to this email directly, view it on GitHub https://github.com/openhab/org.openhab.binding.zigbee/pull/817#issuecomment-1852724567, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEOK5JHMM6OHKE3P53KXSDLYJC2JNAVCNFSM6AAAAABAQXDFT2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJSG4ZDINJWG4 . You are receiving this because you are subscribed to this thread.Message ID: @.***>

--


FranzSchi commented 6 months ago

in console: bundle:update -r org.openhab.binding.zigbee/4.1.0.M4 https://openhab.jfrog.io/artifactory/libs-snapshot-local/org/openhab/addons/bundles/org.openhab.binding.zigbee/4.1.0-SNAPSHOT/org.openhab.binding.zigbee-4.1.0-20231213.033606-7.jar

FranzSchi commented 6 months ago

IMG_0339 Seems my devices that have a voltage attribute are reporting again. Temp and Hum.

rkoshak commented 6 months ago

I see the Jfrog build worked again too. I've now access to the jar but not access to my OH install (my internet is down and apparently I've some external dependency on my LAN that I was unaware of as I cannot now reach my OH machine, investigations are ongoing but unlikely to be resolved before my internet comes back online). I'll test ASAP just to provide another data point but @FranzSchi's results look like it's fixed to me.

Maybe here? https://openhab.jfrog.io/ui/native/libs-snapshot-local/org/openhab/addons/bundles/org.openhab.binding.zigbee/4.1.0-SNAPSHOT/

Until late yesterday (my time) the only files there were from the November 19th build. Now it looks like the add-on has been through the full regular build process and the latest files have yesterday's date. I'm pretty sure the fix is now in the current snapshot too.

rkoshak commented 6 months ago

Internet is back and I was able to upgrade to the snapshot. No more error. Looks like it's fixed correctly. Many thanks @cdjackson !