search

openhab / org.openhab.binding.zwave

openHAB binding for Z-Wave
Eclipse Public License 2.0
170 stars 202 forks source link

Problem with secure random generation of network key #1075

Open cdjackson opened 5 years ago

cdjackson commented 5 years ago

@dbadia we are seeing a number of problems with the new secure random number generation - it seems to be causing machines to lock up on initialisation. There have been a few instances of this - I've referenced the first below, but I've seen another one or two such problems, and we will soon have the 2.4 release version, and I'm worried that this will cause a big problem then.

Please can you investigate this otherwise I think we need to revert this change before 2.4 is released (in early December).

https://community.openhab.org/t/solved-zwave-binding-not-working-since-openhab2-2-4-0-snapshot/56988/12

dbadia commented 5 years ago

I can't reproduce the timeout here, so I am going to post a manual build to the original thread to see if someone there can test the fix. Will submit the PR after that

cdjackson commented 5 years ago

@dbadia can I suggest that we should revert the secure random change for now Dave? Time is running out and I don't want to have this bug in the 2.4 release as we'll have to live with it for the next 6 months.

dbadia commented 5 years ago

Agreed @Chris. Do you want me to submit a PR to back it out?

On Sun, Dec 2, 2018, 11:56 AM Chris Jackson <notifications@github.com wrote:

@dbadia https://github.com/dbadia can I suggest that we should revert the secure random change for now Dave? Time is running out and I don't want to have this bug in the 2.4 release as we'll have to live with it for the next 6 months.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openhab/org.openhab.binding.zwave/issues/1075#issuecomment-443522555, or mute the thread https://github.com/notifications/unsubscribe-auth/AAgHp5IfxGCpUjfXznRpLhf-1qNKFeqwks5u1AYzgaJpZM4YxZT8 .

cdjackson commented 5 years ago

Let's see if I can just revert https://github.com/openhab/org.openhab.binding.zwave/pull/1032

cdjackson commented 5 years ago

Ok, that didn't work. Yes, if you can provide a PR that would be appreciated. I'm happy to add it back again after 2.4 is released (a couple of weeks) and we can work out what is happening.

dbadia commented 5 years ago

Sure, submitted #1079

On Sun, Dec 2, 2018 at 1:11 PM Chris Jackson notifications@github.com wrote:

Ok, that didn't work. Yes, if you can provide a PR that would be appreciated. I'm happy to add it back again after 2.4 is released (a couple of weeks) and we can work out what is happening.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openhab/org.openhab.binding.zwave/issues/1075#issuecomment-443529144, or mute the thread https://github.com/notifications/unsubscribe-auth/AAgHp6Db-NIcamst6a5fTEouE66MU4GZks5u1BftgaJpZM4YxZT8 .

mhilbush commented 5 years ago

Should this be closed?

dbadia commented 4 years ago

Yes, it should be