openhab / org.openhab.binding.zwave

openHAB binding for Z-Wave
Eclipse Public License 2.0
170 stars 202 forks source link

[Database] #1531

Closed bwosborne2 closed 3 years ago

bwosborne2 commented 3 years ago

Database updates seem to be working for 2,5,x but not main or 3.x branches.

The Zooz ZEN34 xml is out of date here compared to the database.

openhab-bot commented 3 years ago

This issue has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/zooz-zen34-remote-switch-unknown-device/115059/14

cdjackson commented 3 years ago

Database updates are only done for the master and 2.5 branches - not the 3.x branch. I’ve not checked specifically, but it strange if they are working for one branch then I don’t really know why it would have stopped on another as it’s all running from fundamentally the same script. I will take a look at this toward the end of next week once the shippers have been.

bwosborne2 commented 3 years ago

It appears they got politically correct and renamed master to main

cdjackson commented 3 years ago

What do you mean? Do you mean that the repository has changed the name of the master branch? I’ve not seen any issue or notes on this in the repository so that’s rather annoying if that’s happened!!! Crazy.

I will look at this in a week or so - at the moment I’m up to my neck in shipping details with exactly 1 week before shippers arrive :(

bwosborne2 commented 3 years ago

image

bwosborne2 commented 3 years ago

Would it make sense for me to change the scripts and try?

cdjackson commented 3 years ago

I don’t know who changed that, but it seems crazy to make such a fundamental change without any consultation with repository maintainers at least!

bwosborne2 commented 3 years ago

I just searched and, although new repos get that naming, I saw no indication of an automatic change. Just an indication of the crazy world today. Supposedly "master" is associated with slavery. They may have used this GH "feature"

image

Renaming a branch will:

Re-target any open pull requests Update any draft releases based on the branch Move any branch protection rules that explicitly reference the old name Update the branch used to build GitHub Pages, if applicable Show a notice to repository contributors, maintainers, and admins on the repository homepage with instructions to update local copies of the repository Show a notice to contributors who git push to the old branch Redirect web requests for the old branch name to the new branch name Return a "Moved Permanently" response in API requests for the old branch name

Roagert commented 3 years ago

Yeah im missing a device that is listed in the opensmarthouse database. I could really use a database update. :) Sounds strange that they would make such a big change

bwosborne2 commented 3 years ago

I hope to take a look at it this evening. I have a couple of ideas top at least get it more current.

Roagert commented 3 years ago

Im actually still missing this device to be update strangely enough. https://opensmarthouse.org/zwavedatabase/1000

bwosborne2 commented 3 years ago

Im actually still missing this device to be update strangely enough.

Not too strange. That device was only approved on 2/9, after the export the PR above is based on. There are still 3.x update issues and real life is adjusting priorities. Are you running version 3.x or 2.5.x ? This device MAY be in the latest 2.5.x snapshot.

Roagert commented 3 years ago

Im actually still missing this device to be update strangely enough.

Not too strange. That device was only approved on 2/9, after the export the PR above is based on. There are still 3.x update issues and real life is adjusting priorities. Are you running version 3.x or 2.5.x ? This device MAY be in the latest 2.5.x snapshot.

I see, yeah no problem. real life comes first :) I am running 3.x version. Because i couldnt see the device being "updated" with the additional parameters i have added i tried to load my own jar file to the addon folder. But when i did that there were other issues that appeared. So im kinda missing a straight forward guide on how to make local changes in a binding so i can test out some features before populating it to the database. Do you know of such a guide somewhere ?

bwosborne2 commented 3 years ago

Because i couldnt see the device being "updated" with the additional parameters i have added i tried to load my own jar file to the addon folder.

If you have the latest snapshot jar of the binding it should work for you. I may get a chance to look at the export process but I have not been involved with that part previously.

But when i did that there were other issues that appeared. So im kinda missing a straight forward guide on how to make local changes in a binding so i can test out some features before populating it to the database. Do you know of such a guide somewhere ?

Actually I do know of one but have not tried it in a while. I believe ESH-INF got replaced by OH-INF though https://community.openhab.org/t/modify-a-zwave-binding-jar-to-add-change-a-zwave-device-while-waiting-for-a-build/47326

williamkennyAK commented 3 years ago

Changing the structure to OH-INF does appear to work with the 3.0 binding, however, it seems sadly my device isn't 100% working yet. It does not show status changes but that may be because I'm doing something wrong. I'm VERY new to using zwave on openHAB and openHAB itself and only have used 3.0. Can you use the 2.5 binding on 3.0?

bwosborne2 commented 3 years ago

Did you try deleting & re-adding the Thing after making the binding changes?

Can you use the 2.5 binding on 3.0?

No you cannot.

If needed I can try & submit another PR to update but somebody else would need to approve & merge.

In my other PR Chris said it would likely be a week or so before he has time to look at the process. I took a quick look and would need to set up a special environment because I do not have the same server access.

bwosborne2 commented 3 years ago

Looks like @cdjackson has the process running again.