openhab / org.openhab.binding.zwave

openHAB binding for Z-Wave
Eclipse Public License 2.0
171 stars 202 forks source link

Philio PST02A Slim Multi-Sensor configuration not possible for some parameters #1547

Closed chris922 closed 3 years ago

chris922 commented 3 years ago

The Philio PST02A has really strange configuration parameters. One parameter can configure several functionalities at the same time by setting the bits to 0/1 of one parameter.

For example a very similar device (PST02C) has the possibility to enter the plain number so all functionalities could be changed by calculating the number based on the bits that should be set. For the PST02A this is only possible for some parameters, but not for the following ones:

I had a look at the XML associated to this device in this repository and maybe just a <limitToOptions>false</limitToOptions> is missing for these parameters. E.g. here: https://github.com/openhab/org.openhab.binding.zwave/blob/b9433110776973e315a001c9966dc53aa35fa308/src/main/resources/OH-INF/thing/philio/pst02a_0_0.xml#L128-L139

For parameters 5 and 7 min/max is also set to 0/127, but having 8 possible bits to set this number range will not allow to set the bit 7. I think min=-128 and max=127 would be correct to allow 10000000 or should it be min=0 and max=255?

I don't know how these "database updates" are working, I just see that they will do the XML changes. So maybe there is some other source that generates these changes. If not and just limitToOptions needs to be added please let me know, then I can create a PR for this.

chris922 commented 3 years ago

I tried to fix this by manually changing the XML, see #1550 .. I would love to get this already in place for the upcoming 3.1.0 release

cdjackson commented 3 years ago

Please update the database at opensmarthouse.org. Updates directly into the binding will not be accepted as they will just be overwritten within a few days from the database export.

chris922 commented 3 years ago

Aah thanks for the fast response!

I thought there will be a different place to do the updates seeing all your database imports. How can I update it on opensmarthouse.org? I just opened a ticket to get editor privileges so that I can update the entry there.

chris922 commented 3 years ago

Fixed by latest database update within #1552