search

openhab / org.openhab.binding.zwave

openHAB binding for Z-Wave
Eclipse Public License 2.0
170 stars 202 forks source link

DimmableLight category seems deprecated #1731

Open m4rcu5 opened 2 years ago

m4rcu5 commented 2 years ago

While tracing down a 404 on an icon in the openHAB interface, I noticed that my zwave dimmers got their category set to DimmableLight by default. Most likely due to the following statement.

https://github.com/openhab/org.openhab.binding.zwave/blob/4c6d5ba3d3be93144f8bbef0a4443daac7f76e57/src/main/resources/OH-INF/thing/channels.xml#L1263

While digging further to see why that icon is throwing a 404, it seems that the DimmableLight category is deprecated and removed from openHAB: https://github.com/openhab/openhab-core/pull/1915

Other bindings have acted upon that change by replacing DimmableLight by Light, see hue and milight.

Should the zwave binding be updated as well?

lolodomo commented 2 years ago

Yes it must be changed. I submitted a PR last weekend for all bindings in the addon repo.

m4rcu5 commented 2 years ago

@lolodomo did you include the zwave binding as well in that PR?

lolodomo commented 2 years ago

No Z-Wave binding was not included in my PR. As it is in a separate repo, a new PR is required.

openhab-bot commented 2 years ago

This issue has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/zwave-fibaro-dimmer-2-fgd212-not-able-to-set-dimmer-value/137689/7