search

openhab / org.openhab.binding.zwave

openHAB binding for Z-Wave
Eclipse Public License 2.0
170 stars 202 forks source link

Shall we run mvn spotless:apply ?? #1909

Open andrewfg opened 6 months ago

andrewfg commented 6 months ago

While working on a PR for this repository, I noticed that running 'mvn spotless:apply' results in many tens of files being reformatted.

As it is now common practice in openhab-core and openhab-addons to keep all source files spotless compliant, I wonder if we should do the same here? => If there are no objections, I would myself be quite happy to create a PR with spotless applied.

Signed-off-by: Andrew Fiddian-Green software@whitebear.ch

cdjackson commented 6 months ago

This has been discussed in the past and I'm personally not keen as it looses a lot of history and IIRC from previous discussions, also changes the XML files which will be changed back with the next update.

andrewfg commented 6 months ago

changes the XML files which will be changed back with the next update.

From memory, it seemed to me that most of the format corrections were applied to java files and not xml files. Or??

cdjackson commented 6 months ago

Ok, maybe I remembered that incorrectly, or possibly an exception was added to avoid changes. In any case the main point was I’d prefer not to loose the history and just do the updates as the files are touched rather than in one large reformat.