search

openhab / org.openhab.ui.habmin

HABmin - a graphical user interface for openHAB 2
231 stars 91 forks source link

Action buttons that are not advanced don't show when 'show advanced settings' is selected #137

Closed marcelrv closed 8 years ago

marcelrv commented 8 years ago

In my xml I defined 2 action buttons, one advanced, the other not. The one that is not advanced does not show when 'show advanced settings' is selected. I would expect both buttons to show at that time

            <!-- Trigger reset action from habmin menu -->
            <parameter name="action-cubeReset" type="integer" groupName="actions">
                <label>Reset Cube Configuration</label>
                <description>Reset the MAX! Cube room and device information. Devices will need to be included again!</description>
                <default>-1</default>
                <advanced>true</advanced>
            </parameter>
            <!-- Trigger reboot action from habmin menu -->
            <parameter name="action-cubeReboot" type="integer" groupName="actions">
                <label>Restart Cube</label>
                <description>Restarts the Cube.</description>
                <default>-1</default>
                <advanced>false</advanced>
            </parameter>
cdjackson commented 8 years ago

Yes, both should be displayed in this case.

cdjackson commented 8 years ago

This should be fixed now - if you're using source. I'll compile up a new version tomorrow probably as have a few more things to finish first.

marcelrv commented 8 years ago

Super fast! Thanks Np, my PR with this combination isn't merged yet. Op 14 mrt. 2016 00:11 schreef "Chris Jackson" notifications@github.com:

This should be fixed now - if you're using source. I'll compile up a new version tomorrow probably as have a few more things to finish first.

— Reply to this email directly or view it on GitHub https://github.com/cdjackson/HABmin2/issues/137#issuecomment-196079708.