openhab / org.openhab.ui.habmin

HABmin - a graphical user interface for openHAB 2
231 stars 91 forks source link

Last release lacks APK file #151

Closed IzzySoft closed 8 years ago

IzzySoft commented 8 years ago

Hiya,

the latest release somehow misses the .apk. Would you consider attaching that in the releases/ section as well? For some background, my repo-updater could fetch it from there automatically. That is, provided the Manifest identifies it with the correct version as well – the last one (HABmin2-0.0.15.apk) presented itself as "1.0.0":

package: name='com.cd_jackson.habmin' versionCode='10000' versionName='1.0.0'

Thanks in advance!

IzzySoft commented 8 years ago

Um … any chances, or not? Or just undecided? ;)

cdjackson commented 8 years ago

Not undecided - just not had the chance to look at this. When I merged the versions back in January I found that it no longer compiled, and I’ve not had the chance to look at it yet - sorry - there’s a lot happening…

On 1 May 2016, at 19:17, Izzy notifications@github.com wrote:

Um … any chances, or not? Or just undecided? ;)

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/cdjackson/HABmin2/issues/151#issuecomment-216061855

IzzySoft commented 8 years ago

Thanks for the feedback! No pressure then. I just wasn't sure if the issue was noticed at all. Considering it's no longer compiling currently, there's nothing you can do now – so if you say as soon as the next release is due, and does compile, you'll attach the .apk again, I'll be patient and look forward to that :smiley_cat:

cdjackson commented 8 years ago

It’s the cordova part that’s not compiling. It looks like the compiler changed. So the main HABmin source is ok, but the integration with Cordova is the issue, and this is what produces the APK. I’ll try and find a few minutes some time to look at this since I do want to restore this feature...

IzzySoft commented 8 years ago

Any luck so far? Not pressing (you take your time when you can), just asking :)

cdjackson commented 8 years ago

Sorry - no, I've not had a chance to look at this. Cordova has gone through a few updates - I think I was using version 3, and it's now on version 6. I'll try and find a few minutes over the next day or so to see if it's simple to upgrade (I would hope and expect so, but let's see)...

IzzySoft commented 8 years ago

I keep my fingers crossed it will be just a simple update to get it working again. Looking forward to the .apk – whenever it is ready. I might ping you again in a couple of weeks if I hear no news, if that's OK for you (just giving a reminder ;)

cdjackson commented 8 years ago

I have an APK generated - just waiting for my old Note2 to charge to see if it works...

cdjackson commented 8 years ago

It works…

I need to work on it a bit to make it properly usable again, but it does run at least. Give me a few days to sort this out - and yes, you can hassle me if you don’t hear from me in a few days :)

cdjackson commented 8 years ago

please email me directly - chris -at- cd-jackson.com and I'll send you an APK to try - my old Note2 is playing up! :(

I've also updated the build to automatically increment the versionCode and sync the versionName.

cdjackson commented 8 years ago

This is now included in the release again.

Any problems, please open separate issues.

IzzySoft commented 8 years ago

Thanks a lot! But is it intended that each .apk claims to be version 1.0.0 instead of reflecting the real version? Causes conflicts when multiple versions reach the repo, so no auto-update possible. Just asking :)

cdjackson commented 8 years ago

I’ll update this - it should be linked automatically - I recently added a script to update the androidVersionCode automatically which was the latest issue, but the version in theory should have been linked already. Can you open a separate issue.

On 19 Jun 2016, at 11:42, Izzy notifications@github.com wrote:

Thanks a lot! But is it intended that each .apk claims to be version 1.0.0 instead of reflecting the real version? Causes conflicts when multiple versions reach the repo, so no auto-update possible. Just asking :)

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/cdjackson/HABmin2/issues/151#issuecomment-226990498, or mute the thread https://github.com/notifications/unsubscribe/AA_kQyxfdwlu31IzF5PNrr01xRECmoAzks5qNR0IgaJpZM4H97vk.