openhab / org.openhab.ui.habmin

HABmin - a graphical user interface for openHAB 2
231 stars 92 forks source link

Widgets should only be added to the dashboard after clicking on save. #165

Open denniseffing opened 8 years ago

denniseffing commented 8 years ago

When you click on "Add Widget" the widget gets added to the dashboard immediately. If you want to cancel, you have to click on cancel and delete the empty (unconfigured) widget.

Expected behaviour: Only add widgets to the dashboard after clicking on save.

cdjackson commented 8 years ago

I’m not sure I understand.

Currently, I believe the way it should work is -:

You edit a dashboard When you add a new widget it gets added into the editor If you hit cancel, then you’re back to the original If you his save, then the updates are saved.

So, widgets are only added to the saved version, after you hit save. If it doesn’t work like that, then that’s a bug.

denniseffing commented 8 years ago

Okay, I'm gonna elaborate:

The way it should work is: You edit a dashboard When you click on "Add widget", the "Add Widget"-Form opens up If you hit cancel in the "Add widget" form, you get back to the dashboard in edit mode, without any widget added to it If you hit save, then the new widget gets added and its properties are saved.

The way it currently is: You edit a dashboard When you click on "Add widget", the "Add Widget"-Form opens up and a new empty widget is added to the dashboard If you hit cancel in the "Add widget" form, you get back to the dashboard in edit mode, and there is a new widget (which is empty in most cases, because you clicked on cancel and didn't enter any properties) If you hit save, then the new widget gets updated and its properties are saved.

This is just a minor issue which affects usability, because you have to manually delete the newly added widget, even after clicking on cancel in its "Add widgit" form.

cdjackson commented 8 years ago

Ok - understood - I thought you were talking about saving the dashboard, not saving the widget.