search

openhab / org.openhab.ui.habmin

HABmin - a graphical user interface for openHAB 2
231 stars 92 forks source link

Habmin doesn't work with Edge: EventSource is undefined #235

Open dmartinpro opened 7 years ago

dmartinpro commented 7 years ago

As SSE is not supported in Edge, there is an error with Edge (and maybe with with IE, didn't test, don't use it anymore) : EventSource is undefined.

After looking for a workaround, I've found this polyfill may help Edge work with SSE: https://github.com/remy/polyfills/blob/master/EventSource.js

Is it possible to consider such a fix in order to support Edge (mobile and desktop)?

cdjackson commented 7 years ago

I used to use this polyfill (at least I think it was this one) but it started to cause problems elsewhere so I removed it. I’m not too keen to add it in case there are further problems.

I must say I’m surprised Edge doesn’t support SSE :(

dmartinpro commented 7 years ago

Maybe this polyfill is a better bet: https://github.com/Yaffle/EventSource

I'll try to give it a try.

SSE is "under consideration" for Edge: it may come in the future (and I hope so, it's the last modern browser not having this feature).

EDIT: it does work with Yaffle's polyfill.

dmartinpro commented 7 years ago

While Paper UI now works, even if not perfect under Edge on a mobile device, Habmin still doesn't have any workaround implemented (As far as I can see). Can the same solution as in Paper UI be implemented?