search

openhab / org.openhab.ui.habmin

HABmin - a graphical user interface for openHAB 2
231 stars 92 forks source link

Add Confirmation Prompt to Z-Wave Advanced Settings #237

Open PascalTurbo opened 7 years ago

PascalTurbo commented 7 years ago

For the Advanced Settings in Z-Wave Configuration it's possible to select destructive options like "Hard Reset Controller" without any security prompt. So with a single click a user is able to destroy it's whole Z-Wave network by accident.

I would prefer a dialog which tells the user what will happen and forces him to confirm its selection.

cdjackson commented 7 years ago

I would agree but I don't know w how we can define this. There is no such option in ESH so I don't think this is possible - sorry.

Sent from my iPhone

On 4 Oct 2016, at 16:07, PascalTurbo notifications@github.com wrote:

For the Advanced Settings in Z-Wave Configuration it's possible to select destructive options like "Hard Reset Controller" without any security prompt. So with a single click a user is able to destroy it's whole Z-Wave network by accident.

I would prefer a dialog which tells the user what will happen and forces him to confirm its selection.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

PascalTurbo commented 7 years ago

Maybe we could create a feature request to ESH?

cdjackson commented 7 years ago

I thought about this after your issue request and decided it was a good move so I already made a PR…

https://github.com/eclipse/smarthome/pull/2258 https://github.com/eclipse/smarthome/pull/2258

I need to tidy it up some more over the next week or so...