search

openhab / org.openhab.ui.habmin

HABmin - a graphical user interface for openHAB 2
231 stars 92 forks source link

Context of password not handled correctly for thing config parameter #247

Open mhilbush opened 7 years ago

mhilbush commented 7 years ago

The following thing config parameter specification should display the information masked.

            <parameter name="password" type="text" required="true">
                <label>Password</label>
                <description>Password used to login to SunsetWx service</description>
                <context>password</context>
            </parameter>

Here's how it looks in PaperUI. capture

cdjackson commented 7 years ago

I've just added code to support this (hopefully) - @mhilbush can you test please (I'll kick off a build in a few minutes).

mhilbush commented 7 years ago

Looks like it's still picking up the old template.

Way out of my area of knowledge... But, is the order of the entries in eshConfigParam.tpl.html important?

Will this be selected <div ng-if="config.options==null || config.options.length==0">

before this? <div ng-if="()config.options==null || config.options.length==0) && config.context=='password'">

cdjackson commented 7 years ago

Yes - you might be right. I also see that Eclipse nicely added a closed bracket for me so the condition doesn’t work in any case. I’ll update in a few minutes.