Don't reset authorization header if no auth data is stored

openhab / org.openhab.ui.habmin

HABmin - a graphical user interface for openHAB 2

231 stars 92 forks source link

Don't reset authorization header if no auth data is stored #265

Closed jvolkman closed 7 years ago

jvolkman commented 7 years ago

Habmin resets the Authorization header when clearing stale saved auth info, but does so even if no auth info was saved (e.g., when using nginx for authentication instead). This is the cause of #220.

This change only clears the auth header when stale saved data is actually being cleared as well.

cdjackson commented 7 years ago

Thanks.

roben commented 7 years ago

Can this be added to the master branch? I fear that the change gets lost otherwise in the next release. Also: Is there a way to release this to the official distro so that it is updated automatically by openhab rather than to have to build the jar by myself?

cdjackson commented 7 years ago

Good point - I hadn't noticed that this was only against the 2.0.x branch which I don't think this will ever be used. @jvolkman can you provide a PR against master please?