openhab / org.openhab.ui.habmin

HABmin - a graphical user interface for openHAB 2
231 stars 92 forks source link

HABmin "loses" item-channel links #285

Open mhilbush opened 5 years ago

mhilbush commented 5 years ago

For a very long time I've seen the situation where HABmin loses the item-channel links. This manifests itself in the HABmin UI on the Thing display. The Channels pane shows 0 Active channels, when in fact there are one or more than one Active channels. Opening the Channels pane shows all the channels, but the items linked to those channels are gone.

Doing a page reload corrects the problem.

I believe I've tracked this down to the scenario where the status of the thing has changed. The best example is when the Last Wakeup Time attribute is updated.

Scenario to reproduce:

I tried to trace through the Angular code to see what's going on. Unfortunately, my Angular skills are really poor. ☹️

grizzlyfred commented 5 years ago

Same in paper UI - out of several things set up on 2.4.0 snapshot 4 most from yesterday evenings session have vanished in "control", and most of the things I wanted as an initial setup never worked without giving a clue as to why. In "simple linking mode" clicking on the individually offered functions(items) does nothing at all.

Actually, from my evaluation setup only the tp link wifi switches and the air quality really worked longer then a couple of hours, I grieve for the time lost... OH2 does imo a lot of stuff, but unfortunately without stability or reliability or easy traceability / clear error messages - not even in the log.

5iver commented 5 years ago

Same in paper UI

@grizzlyfred , I believe what you are reporting is a separate issue. However, I have also noticed some new behavior in recent snapshots, where Items linked to Channels of Things that are offline are no longer controllable in Basic UI. I haven't yet tracked down the change that introduced this, but I planned to open an ESH issue (this would be framework) when I had more information. I have noticed this with Items linked to Channels of both Zwave and Zigbee Things that are offline or have lost their handler. I never use the Paper UI> Control, but I expect that they would also be missing there.

This is a bit of a pain, since a motion sensor that is offline will keep my lights on, and there is no longer a way to manually trigger the rule to shut them off, since the Item no longer responds.

cdjackson commented 5 years ago

If the links are getting lost, then that’s not an issue with HABmin - it’s a problem with the core somewhere. I think what Mark was reporting here is that under some circumstances HABmin can display the links wrong, and I think in this case a refresh of HABmin will fix it.

If links are not working, and the simple mode is not working, then that’s not a UI issue (be it HABmin or PaperUI).

On 28 Oct 2018, at 16:39, Scott Rushworth notifications@github.com wrote:

Same in paper UI @grizzlyfred https://github.com/grizzlyfred , I believe what you are reporting is a separate issue. However, I have also noticed some new behavior in recent snapshots, where Items linked to Channels of Things that are offline are no longer controllable in Basic UI. I haven't yet tracked down the change that introduced this, but I planned to open an ESH issue (this would be framework) when I had more information. I have noticed this with Items linked to Channels of both Zwave and Zigbee Things that are offline or have lost their handler. I never use the Paper UI> Control, but I expect that they would also be missing there.

This is a bit of a pain, since a motion sensor that is offline will keep my lights on, and there is no longer a way to manually trigger the rule to shut them off, since the Item no longer responds.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/openhab/org.openhab.ui.habmin/issues/285#issuecomment-433721155, or mute the thread https://github.com/notifications/unsubscribe-auth/AA_kQ0gHBbA66-kcrAVTPA3q8hlPB4luks5upd3MgaJpZM4VGYJG.

kaikreuzer commented 5 years ago

where Items linked to Channels of Things that are offline are no longer controllable in Basic UI

@openhab-5iver I think this is YET another issue that you are reporting because in this case, the links are still there (you will see the controls in Paper UI). Actually, this is not a bug, but completely intended and was inroduced with https://github.com/eclipse/smarthome/pull/5011 - if you send a command to an item that has a single channel, where the Thing is offline, the auto-update isn't triggered. It should not prevent you from manually switching off your lights though as I would expect that your light still needs to be online in order to be switched off.

mhilbush commented 5 years ago

To clarify, this issue I opened here, as @cdjackson points out, is strictly a UI presentation issue in HABmin.