search

openhab / org.openhab.ui.habot

A chatbot for openHAB using machine-learning natural language processing from OpenNLP
Eclipse Public License 1.0
65 stars 31 forks source link

Some native German corrections #19

Closed stritti closed 6 years ago

ghys commented 6 years ago

Awesome, thanks @stritti! Just two small things: first, looking at the diff it appears your editor has transformed the encoding of the properties file to UTF-8, can you make sure it's encoded in ISO 8859-1? see https://stackoverflow.com/a/34718980. I'll move them to XML one day... Second, could you sign off the commit or add a sign off line here? ;)

stritti commented 6 years ago

Sorry the conversion was caused by editing directly on GitHub. I lost the thread. Now it is again ISO 8859-1.

Signed-off-by: Stephan Strittmatter <stephan.strittmatter@gmail.com> (github: stritti)

ghys commented 6 years ago

Great 👍 Now there's build errors caused by (I assume) refactorings in ESH so I need to fix them first and will merge this afterwards. Thanks again!