Open kubawolanin opened 5 years ago
Travis rejected my PR but it's not my fault 😄
[INFO] --- sat-plugin:0.5.0:report (default) @ org.openhab.ui.habot ---
[INFO] Individual report appended to summary report.
[ERROR] Code Analysis Tool has found:
1 error(s)!
71 warning(s)
15 info(s)
[WARNING] .ui.habot/README.md:[11]
The line after a Markdown list must be empty.
[ERROR] .ui.habot/META-INF/MANIFEST.MF:[0]
The manifest version did not match the requirements ^2.4.0
Cool feature @kubawolanin (and nice to see you back! 🎉) It's something I have been considering as well but never took the time ;)
One little problem I see is that the array of previous commands will never stop growing - maybe consider using SessionStorage instead? (or keep e.g. the last 50 commands)
Travis rejected my PR but it's not my fault
Yes it's been fixed as part of #32 - should be good now if you rebase.
Closes #33
Signed-off-by: Kuba Wolanin hi@kubawolanin.com