search

openhab / org.openhab.ui.habpanel

OUTDATED repo - HABPanel has moved to the openhab-webui repo!
https://github.com/openhab/openhab-webui
Eclipse Public License 1.0
97 stars 92 forks source link

Enhancement: ExternalScripts, getItem, and milliseconds option for image #129

Closed LuckyMallari closed 7 years ago

LuckyMallari commented 7 years ago

My Changes: https://github.com/LuckyMallari/org.openhab.ui.habpanel

ExternalScripts: Basically, it adds ../static/habpanel/externalscripts.js to head Users can then create their own scripts (Angular or not) to their hearts' content.

getItem() returns item (to access all properties)

Milliseconds: Image $interval now has 2 options: seconds (default) or milliseconds. Does not break existing install/configs.

kubawolanin commented 7 years ago

Adding #128 for reference.

ghys commented 7 years ago

ExternalScripts: Basically, it adds ../static/habpanel/externalscripts.js to head Users can then create their own scripts (Angular or not) to their hearts' content.

Sorry, I don't agree with this solution. You can actually lazy load external resources using the ocLazyLoad directive (https://oclazyload.readme.io/docs/oclazyload-directive) but I'm now realizing there is a big security hole with this. I need to address this ASAP.

getItem() returns item (to access all properties)

This is already covered by #114 which was submitted first.

Milliseconds: Image $interval now has 2 options: seconds (default) or milliseconds. Does not break existing install/configs.

Can you please submit a separate PR for this?

Thank you!

ghys commented 7 years ago

I need to address this ASAP.

Partial mitigation measure in #132 ...it's a shame it didn't make 2.0.0.

LuckyMallari commented 7 years ago

Closing issue. Opened a new PR here: https://github.com/openhab/org.openhab.ui.habpanel/issues/133