search

openhab / org.openhab.ui.habpanel

OUTDATED repo - HABPanel has moved to the openhab-webui repo!
https://github.com/openhab/openhab-webui
Eclipse Public License 1.0
96 stars 92 forks source link

Bugfix for translation of ON / OFF values to numbers #349

Closed elisman closed 5 years ago

elisman commented 5 years ago

Also apply the computed value to the datapoint state.

ghys commented 5 years ago

Hi @elisman, thanks for your patch - it makes sense indeed! 😄 👍 May I ask you for a Signed-off-line as per our contributing rules - those are mandatory in our project even for small patches when they involve code. If you don't want to amend your commit, just reply here with it like (use your real name & email):

Signed-off-by: Joe Smith <joe.smith@email.com>

and I will add it for you when merging. Thank you in advance!

elisman commented 5 years ago

Hi @ghys, sorry for not signing the work as per contributing rules. Indeed, I thought such a small change shouldt be done quickly.

If you don't want to amend your commit, just reply here with it like (use your real name & email):

Please add it when merging.

Signed-off-by: Elisei Rotaru <Elisei.Rotaru@gmail.com> (github: elisman)

Thanks!

ghys commented 5 years ago

Thank you @elisman 👍

lblabr commented 5 years ago

how do i get this version of habpanel in my installation ?