search

openhab / static-code-analysis

Maven tooling for static code analysis
https://www.openhab.org/
Other
32 stars 21 forks source link

Moved "ESH-INF/" folders to "OH-INF/" folders #371

Closed cweitkamp closed 4 years ago

cweitkamp commented 4 years ago

Related to https://github.com/openhab/openhab-core/pull/1328

Signed-off-by: Christoph Weitkamp github@christophweitkamp.de

wborn commented 4 years ago

Since these changes won't be compatible with OH 2.5.x, I'd prefer to do one final SAT release that is compatible with OH 2.5.x. Preferably that release also has https://github.com/openhab/static-code-analysis/pull/365 so we can also significantly reduce the 2.5.x PR build times. WDYT @openhab/sat-maintainers?

kaikreuzer commented 4 years ago

Yes, yes, I wanted to look at #365 since a long time... Will try to review/merge it this weekend and do a new SAT release with it, ok?

wborn commented 4 years ago

Sounds good to me! :-)

kaikreuzer commented 4 years ago

@cweitkamp If you'd address the review comments, we should be good to merge.

cweitkamp commented 4 years ago

I must have missed those comments. Will take care of it soon.

cweitkamp commented 4 years ago

Done. I hope I found all occurrences.