search

openhab / static-code-analysis

Maven tooling for static code analysis
https://www.openhab.org/
Other
32 stars 21 forks source link

Switch to Java 11 and upgrade JAXB #373

Closed wborn closed 4 years ago

wborn commented 4 years ago

When #371 is merged SAT won't be compatible with OH 2.5.x anymore so that would also allow us to make it Java 11 only.

Upgrading JAXB fixes the "illegal reflective access operations" warnings reported in #366.

There's still one such warning remaining due to the spotbugs-maven-plugin usage of the Groovy ReflectionUtils class.

See: https://github.com/spotbugs/spotbugs-maven-plugin/issues/132

wborn commented 4 years ago

If we decide to keep the manifest checks (see #341, #364) we should also update the Java version in the checks/tests/configuration, e.g.:

https://github.com/openhab/static-code-analysis/blob/2e148f3e2165778e3cb45f316ecf56585cb0369b/custom-checks/checkstyle/src/main/java/org/openhab/tools/analysis/checkstyle/ManifestJavaVersionCheck.java#L24

https://github.com/openhab/static-code-analysis/blob/2e148f3e2165778e3cb45f316ecf56585cb0369b/sat-plugin/src/main/resources/rulesets/checkstyle/rules.xml#L92