Cleanup code - Githubissues

openhab / static-code-analysis

Maven tooling for static code analysis

https://www.openhab.org/

Other

32 stars 21 forks source link

Cleanup code #458

Closed wborn closed 8 months ago

wborn commented 8 months ago

This cleanup includes:

Fix deprecations
Fix format argument mismatches
Fix JavaDocs
Fix typos
Remove redundant boxing
Remove redundant imports
Remove redundant modifiers
Remove redundant toString calls
Remove redundant variable initialization
Use diamond operator
Use enhanced for loops
Use secure URLs with XML
Use try-with-resources with Files.list
Replace Collectors.joining with String.join
Replace lambdas with method references

wborn commented 8 months ago

IntelliJ IDEA helps me find all these issues and it can also fix most automatically which saves a lot of time and regressions! Usually I analyze all the code and only fix a subset of all the found issues. It can also analyze all code using one rule which helps if you want to fix one or two problems in a lot of code like https://github.com/openhab/openhab-addons/pull/16249. I use both Eclipse and IntelliJ IDEA but didn't use IDEA yet with openHAB.