search

openhab / website

This repository contains the final artifacts from which the project website is served.
https://www.openhab.org/
20 stars 47 forks source link

Fix Firefox Mobile layout problem #298

Closed DarkC35 closed 3 years ago

DarkC35 commented 3 years ago

This PR fixes a problem with responsive layout of Firefox for Android.

To reproduce simply use the firefox app or the firefox screen-size test feature of the developer tools and go to an openHAB page like https://www.openhab.org/addons/

grafik

For a bief moment you can see that it scales the site like it should be but it falls back to desktop mode eventually.

This behavior seems to persist since vuepress 1.4.1, you can read more about this here: https://github.com/vuejs/vuepress/issues/2369

Signed-off-by: Kevin Haunschmied darkc.futarialone@gmail.com

Confectrician commented 3 years ago

CC @ghys we then should cherry pick this one into v2 branch too. This should be no problem with your latest updates correct?

DarkC35 commented 3 years ago

Thanks for merging @Confectrician now I'm finally albe to use the site on Fenix too :)

FYI, as it is mentioned in the linked issue above, the official vuepress site https://vuepress.vuejs.org/ is also affected. I just checked the site for the next version https://v2.vuepress.vuejs.org/ and this version seems to have fixed it somehow. Just as a small hint when vuepress v2 gets a stable release ;D

Confectrician commented 3 years ago

Maybe we should have an eye on vitepress in the future too anyway. 🙂 This fix should affect our next.openhab.org site and the stable site served via www.openhab.org.

We still need this then cherry picked into the v2 branch here to get it working for v2.openhab.org as well.

ghys commented 3 years ago

CC @ghys we then should cherry pick this one into v2 branch too. This should be no problem with your latest updates correct?

Hopefully, yes. There are no concrete plans to migrate to VuePress v2 or VitePress for now but we should consider it - migrating from v0 to v1 involved some work though so we can reasonably anticipate there will be some as well.

Confectrician commented 3 years ago

From what i read the build time should get way better with a stable vitepress instance (which we are pretty far away from currently from my readings)

I will do the cherry pick and website build and see if something breaks.