search

openhab / website

This repository contains the final artifacts from which the project website is served.
https://www.openhab.org/
20 stars 47 forks source link

Enhance rss sorting and dynamic feed meta #329

Closed Confectrician closed 2 years ago

Confectrician commented 2 years ago

Fixes #328

@ghys could you have a lok at that ruby script?

I am no ruby pro and all my skills are related to the doc scripts, so some check would be useful here.

ghys commented 2 years ago

Looks good! Note that the RSS output doesn't include the author (https://deploy-preview-329--openhab.netlify.app/rss.xml) and the Atom output doesn't include the image (https://deploy-preview-329--openhab.netlify.app/feed.atom), but that's probably a format limitation.

Confectrician commented 2 years ago

Note that the RSS output doesn't include the author (https://deploy-preview-329--openhab.netlify.app/rss.xml) and the Atom output doesn't include the image (https://deploy-preview-329--openhab.netlify.app/feed.atom), but that's probably a format limitation.

Have seen that too, but as it gets processed to json correct, i am assuming that everything works as expected.

ghys commented 2 years ago

For the author to appear in RSS you need an e-mail address, relevant code of the underlying library that generates the feeds:

https://github.com/jpmonette/feed/blob/34dbde9aa47b85ae207ba4fefe4c5794b8ca43e2/src/rss2.ts#L153-L164

Atom doesn't support images (there's no official element).

Confectrician commented 2 years ago

Hm then we can live without it. We don't have an email adress all the time.