search

openhab / website

This repository contains the final artifacts from which the project website is served.
https://www.openhab.org/
21 stars 47 forks source link

"Download openHAB 4.0.0 SNAPSHOT Add-ons" suggests wrong name #405

Open spacemanspiff2007 opened 1 year ago

spacemanspiff2007 commented 1 year ago

Under download select the following

grafik

Then click on

grafik

Filename has the wrong extension "mid" instead of "kar"

grafik

kaikreuzer commented 1 year ago

Are you sure that your browser isn't doing any fancy stuff?

When I click this button, it is correctly downloading the kar (with this name):

Bildschirmfoto 2023-05-22 um 18 25 45
spacemanspiff2007 commented 1 year ago

The link shows the same for me but in the dialog it changes to .mid.

grafik

Are you sure that your browser isn't doing any fancy stuff?

That's absolutely possible. I am using the latest Firefox on Win10. I do download the snapshots quite often and every time I manually edit the suffix in the dialog yet it pops up again with .mid.

Would it be possible to use the download attribute for the link? That way the filename could be explicitly passed to the browser.

If not and if I am the only one who is having this behavior this issue can be closed.

kaikreuzer commented 1 year ago

I have created https://github.com/openhab/website/pull/407 for it. You can test on https://deploy-preview-407--openhab.netlify.app/download/ whether this resolves the issue for you.

spacemanspiff2007 commented 1 year ago

grafik

After the download there has to be a "=" with the filename - I've left a comment.

Confectrician commented 1 year ago

I will take care of the naming part, when #407 has been merged.

kaikreuzer commented 1 year ago

@Confectrician Thanks a lot - go for it!