search

openhab / website

This repository contains the final artifacts from which the project website is served.
https://www.openhab.org/
20 stars 47 forks source link

Sidebar refactoring #442

Closed stefan-hoehn closed 4 months ago

stefan-hoehn commented 5 months ago

Adds the styles for the new hierarchy arrows in the sidebar which we introduced in https://github.com/openhab/openhab-docs/pull/2198

@Confectrician it seems you were right that adding this style to openhab-docs isn't working.

netlify[bot] commented 5 months ago

Deploy Preview for openhab-v40 failed.

Name Link
Latest commit 78e4f13c903b3eb9d94960f7dc5fbf7c8fdd7646
Latest deploy log https://app.netlify.com/sites/openhab-v40/deploys/65a3c194a743780009bd11a8
stefan-hoehn commented 5 months ago

@kaikreuzer @ghys @Confectrician

Can someone retrigger the build? Looking at the logs, it seems that there was a "Javascript out of heap memory" error.

btw, do we have a group like openhab-webui-maintainer, e.g. openhab-website-maintainers? if not, would that make sense?

florian-h05 commented 5 months ago

btw, do we have a group like openhab-webui-maintainer, e.g. openhab-website-maintainers? if not, would that make sense?

I thinkt the @openhab/foundation-staff team is responsible for the website content.

ghys commented 5 months ago

that there was a "Javascript out of heap memory" error.

This happened before, we were always very tight with heap memory with VuePress. Migrating to the latest version/to VitePress could solve the problem. The Netlify builds configurations already add a command line option to tell Node to increase the heap memory (I can't login at this time).

florian-h05 commented 4 months ago

I am actually not sure if this PR is required. Looking at some of the expandable sidebar entries on the next deployment, they are not greyed, but normally coloured:

IMG_2411

Looking at the docs-sidebar.js in the docs repo, these entries are defined in different ways, I’ll try out something and report back later.

florian-h05 commented 4 months ago

I was wrong, we need the CSS change proposed by Stefan. @kaikreuzer Can you please merge this PR?