search

openhab / website

This repository contains the final artifacts from which the project website is served.
https://www.openhab.org/
20 stars 47 forks source link

Upgrade to Ruby 3.3.2 #468

Closed jimtng closed 2 weeks ago

jimtng commented 3 weeks ago

@florian-h05 could you please test this thanks!

jimtng commented 3 weeks ago

Once @florian-h05 has tested it, would you mind taking a quick look at this @ccutrer? I haven't done any major refactoring, just minor changes to make rubocop happy.

ghys commented 3 weeks ago

Thank you @jimtng for picking up on my messy Ruby code - still my go-to scripting language of choice for 20 years ;)

There's a lot that's changed here but at first glance it looks good. Thanks again!

ccutrer commented 3 weeks ago

My only suggestion would be at some point (not necessarily as part of this PR), commit a Gemfile and Gemfile.lock, so that dependencies (such as Rubocop) won't update unexpectedly, causing build problems.

ghys commented 3 weeks ago

LGTM. About this build failure:

12:12:06 PM: <internal:/opt/buildhome/.rvm/rubies/ruby-3.3.2/lib/ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:136:in `require': cannot load such file -- rexml/document (LoadError)`

I'm not even sure rexml/document is still necessary? I can't remember why it was needed in the first place.

jimtng commented 3 weeks ago

I'm not even sure rexml/document is still necessary? I can't remember why it was needed in the first place.

Removing it fixed the build failure, thanks!