Closed dirkbaechle closed 10 years ago
Thanks for this! Pardon the spurious travis-ci failure.
I expect to pair with someone on reviewing this on Thursday, June 8. Apologies for the long delay. We really value this contribution, and are getting to it as quickly and effectively as we can.
Given the high latency on our end, if we run into issues in the review, we'll probably try to add commits on top to clean them up, rather than ask you to address them. That way, we'll be able to merge it as quickly as possible.
Hi @dirkbaechle !
I left some feedback in the pull request. Having left all that, this is OK to merge as-is. (I'd much prefer if you can simplify in some of the ways I mentioned there, but having support for Tigris is much better than not!)
One thing we will need is a licensing statement from you. You can find information about that here:
Thank you a great deal for writing this. It means a lot to us to see people write new code in oh-bugimporters
, and speaking entirely personally, it is kind of heart-warming to see my Bugzilla XML parsing code copied and modified to do something totally novel. It is like reading about Tigris' XML format, but in my own words, written by someone else.
Thanks for the review,
I added some replies that hopefully clear up the remaining head scratches of yours. You can find my licensing statement here:
http://lists.openhatch.org/pipermail/devel/2014-May/003558.html
If I didn't hit the correct form, please say so...then I can repeat it anytime. Finally, I'd like to ask how to proceed about actually getting this new importer available in OpenHatch itself. Can/will this be done by someone of your team on-the-fly? I could add a new bug for this and try to come up with another pull request, but it would be my first time tinkering with Django. While definitely being a worthwhile experience for me, it might cause you more work that way. ;) Just let me know what you think...
This patch adds a new bug importer for the Tigris XML format.
The "env/bin/py.test" runs successfully on my side. I ran pyflakes over the Tigris Python files without any problems showing up. Additionally, I scraped the current state of the "SCons" Tigris database with the command:
env/bin/scrapy runspider bugimporters/main.py -a input_filename=/tmp/input-configuration.yaml -s FEED_FORMAT=json -s FEED_URI=/tmp/results.json -s LOG_FILE=/tmp/scrapy-log -s CONCURRENT_REQUESTS_PER_DOMAIN=1 -s CONCURRENT_REQUESTS=200
which seemed to work fine (2946 issues, in about 6:30min). I hope the unit tests are sufficient for a start... ;)