openhatch / oh-bugimporters

Bug importers for the OpenHatch project oh-mainline
https://oh-bugimporters.readthedocs.org/
GNU Affero General Public License v3.0
12 stars 28 forks source link

Issues on python.org that are actively being worked on or closed remain in our list of 'open issues'' #71

Closed ghost closed 10 years ago

ghost commented 10 years ago

Comment by mandarg:

Example -- search for 'Volunteer Opportunities' by language 'Python'. [https://openhatch.org/search/?q=&language=Python]

When I do this, the top five issues contain:

  1. http://bugs.python.org/issue19669, which is in Stage 'resolved'
  2. http://bugs.python.org/issue19588, which is in Stage 'patch review'
  3. http://bugs.python.org/issue19626, which is in Stage 'committed/rejected'

It seems to me that these decrease the signal-to-noise ratio a lot for new volunteers looking for open issues to work on. I would say we could restrict our issues to ones in Stage "needs patch" or "test needed".

An unrelated problem is also that the python bugtracker is possibly not always updated, for example, shouldn't http://bugs.python.org/issue1100942 be in Stage "patch-review"? We could also get around this by excluding all issues with a patch attached.


Comment by ehashman:

I'll take a look at this. Sounds like it should be a quick and easy fix.


Comment by ehashman:

Verified that the bug still exists (this bug comes up in a search even though it's in review: http://bugs.python.org/issue9305 and this one is committed/rejected: http://bugs.python.org/issue20145).

Fix for this is to change "closed" to "closed,resolved,patch review,committed/rejected" in the Python tracker configuration in openhatch.org/customs, which I've done. I've also added "commit review" to that based on this bug coming up in search: http://bugs.python.org/issue20627

This config change will cause the affected bugs to be filtered out from search (see bugimporters/roundup.py:201 in oh-bugimporters and mysite/search/models.py:560 in oh-mainline).

Someone should verify that this is working from the next bugimporters crawl.

Possible followup: it appears that python has marked these bugs (http://bugs.python.org/issue20145, http://bugs.python.org/issue20627) as closed, but not in their status. Filtering out the requested statuses as per this fix will probably take care of the majority of closed bugs, but perhaps this other closed field should be investigated.


Comment by ehashman:

I've refiled the second half of the bug report as issue 953: https://openhatch.org/bugs/issue953


Comment by ehashman:

I accidentally put the status change on the wrong comment, sorry! :)

On 2014-04-04 09:14, ehashman wrote: > ehashman <elana@hashman.ca> added the comment: > > I've refiled the second half of the bug report as issue 953: > https://openhatch.org/bugs/issue953 > > ---------- > status: chatting -> need-review > > __ > Roundup issue tracker <bugs@openhatch.org> > <https://openhatch.org/bugs/issue906> > __ > ___ > Devel mailing list > Devel@lists.openhatch.org > http://lists.openhatch.org/mailman/listinfo/devel


Comment by ehashman:

So it's been a couple days and I haven't seen any changes take place. There seem to be two issues here:

1) Bugs that are marked "Status: closed" are not being removed from our bug collection. There's lots of them that have been closed for a while (1+ months) but we still display. This may be a separate issue.

2) I think I've confused the two separate fields of "Status" vs. "Stage". We are pulling the former, not the latter (oops -.-). It shouldn't be too painful to grab the stage info; indeed, it should already be present in the metadata dictionary from the parse. (bugimporters/roundup.py:111) So the question then is how to deal with this specifically in the Python tracker case without making any groundbreaking changes---it would be nice to not have to add a configuration setting for a stage, e.g.

I propose to replace the "Status" value with the "Stage" value if "Status" == open. This has the added benefit of better UX for those browsing in our volunteer opportunities search, as they get more information about the bug status at a glance without having to open the issue. To accomplish this, all that needs to be done is an override of a small piece of functionality in get_parsed_data_dict for the roundup trackers (line 197).


Comment by ehashman:

Fix complete. Opened pull request: https://github.com/openhatch/oh-bugimporters/pull/46


Comment by ehashman:

Pull request has been merged; however, apparently Travis didn't like it very much. Going to leave this open another few days to verify it hasn't broken the bugimporters before closing this issue.


Comment by ehashman:

Changed custom parser to PythonRoundupBugParser for Python. This shouldn't break anything. Waiting on https://github.com/openhatch/oh-bugimporters/pull/49 aka issue962 for the change to take effect.


Status: resolved Nosy List: ehashman, mandarg, paulproteus Priority: urgent Imported from roundup ID: 906 (view archived page) Last modified: 2014-05-04.22:31:38