search

openhatch / oh-bugimporters

Bug importers for the OpenHatch project oh-mainline
https://oh-bugimporters.readthedocs.org/
GNU Affero General Public License v3.0
12 stars 28 forks source link

New bugimporters framework should check on existing bugs #91

Closed ghost closed 10 years ago

ghost commented 10 years ago

Comment by gehrhorn:

Right now there are projects that list bugs in OpenHatch as open, but on the project trackers are closed. For example, this bug for Twisted http://twistedmatrix.com/trac/ticket/5632 is listed as "new" in OpenHatch (goto Python -> Documentation -> Twisted), but the trac ticket on twistedmatrix.com lists the bug as closed.

Comment by paulproteus:

Hi there,

Thanks for finding and reporting this issue!

Having looked into it, the problem is that with a rewrite of the bug import framework, we didn't carry over the ability of the site to correctly detect when bugs that we imported in the past become closed.

It's a serious issue, so thank you!

Comment by paulproteus:

Probably the right fix here is the following:

In oh-mainline: mysite/customs/models.py , change as_dict() to create a new key in the dict called existing_bugs, and make that be a list of all the canonical_bug_link values of all the Bug objects tied to this trackermodel.

In oh-bugimporters: adjust the spider to look for a key called existing_bugs and also crawl those.

That should be it.

Comment by paulproteus:

As an update, https://github.com/openhatch/oh- bugimporters/commit/c415487bcaecf7118b206f94e3f42f0de830cbdf implements the beginnings of the oh-bugimporters requirements for this.

Comment by paulproteus:

https://github.com/openhatch/oh-bugimporters/pull/23 contains a backend that makes this work. If that strategy seems reasonable (please review!), then I have patches to the rest of the backends waiting.

Comment by paulproteus:

jwm indicated on https://github.com/openhatch/oh-bugimporters/pull/23 that this looks good to him, so I'm marking this as resolved!

Status: resolved Nosy List: gehrhorn, jwm, paulproteus, vu2srk Priority: bug Imported from roundup ID: 772 (view archived page) Last modified: 2012-11-26.19:49:08