openhatch / oh-greenhouse

Greenhouse -- a (temporary?) project to help track new contributors to open source projects. Might migrate to oh-mainline eventually.
GNU Affero General Public License v3.0
5 stars 7 forks source link

Fixes to migrate-uploads-data #40

Closed daveeloo closed 11 years ago

daveeloo commented 11 years ago

-removed 'greatest = []', it was being used for testing and should've been removed -several places should have been using "order_by('date')" not "order_by('-date')" -should have been trying to select the first object on the exception -it's taking even less memory than before now, 48MB, have no idea why -decided to keep "gc.collect()", it makes no difference with chunk_size=5000 but with chunk_size=10000 the memory use climbs, not sure why that happens only happens with a larger chunk_size

paulproteus commented 11 years ago

Seems okay to me. In the future we should cover this sort of complicated logic with unit tests.