search

openhatch / oh-mainline

The code that runs openhatch.org
http://openhatch.org
GNU Affero General Public License v3.0
242 stars 310 forks source link

Change "step one" to something more descriptive #1770

Closed li3n3 closed 9 years ago

li3n3 commented 9 years ago

From https://github.com/openhatch/oh-mainline/issues/1753

Nice and small, this one!

...that is, the notstepone branch...which appears to be gathered up in my other PR now. Eep.

codecov-io commented 9 years ago

Current coverage is 78.60%

Merging #1770 into master will not affect coverage as of 3828b26

@@            master   #1770   diff @@
======================================
  Files           70      70       
  Stmts         5931    5931       
  Branches         0       0       
  Methods          0       0       
======================================
  Hit           4662    4662       
  Partial          0       0       
  Missed        1269    1269

Review entire Coverage Diff as of 3828b26

Uncovered Suggestions

  1. +0.51% via ...mplatetags/search.py#49...78
  2. +0.35% via ...mplatetags/search.py#83...102
  3. +0.31% via ...file/view_helpers.py#186...203
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

ehashman commented 9 years ago

Hi @li3n3! Thank you so much for the awesome changeset! I'll take a look in more detail later.

There are too many commits in this set (plus a stray merge commit) to merge this as-is; I'd like to rebase this into fewer, larger commits. This looks like it will be pretty complicated so I'd be happy to help. Can I give you a timeline of sometime in the next two days? Let's maybe link up on IRC.

li3n3 commented 9 years ago

Yep, I'm free most of today in IRC — thank you! I'll close this issue out in favor of the preceding one.